feat: remove multichain accounts pre state 2 UI (account details + wallet details) #37984
+75
−3,436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (4 files, +3 -12)
👨🔧 @MetaMask/core-extension-ux (5 files, +30 -50)
🧪 @MetaMask/qa (2 files, +23 -0)
|
Collaborator
Builds ready [2229dc2]
UI Startup Metrics (1218 ± 83 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [331cdf0]
UI Startup Metrics (1206 ± 89 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [9cb92a9]
UI Startup Metrics (1236 ± 99 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [ac788d8]
UI Startup Metrics (1204 ± 93 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [65eb972]
UI Startup Metrics (1195 ± 99 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [3c2111e]
UI Startup Metrics (1203 ± 83 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [5aaee49]
UI Startup Metrics (1270 ± 104 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [9f7a672]
UI Startup Metrics (1217 ± 99 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [6c9927f]
UI Startup Metrics (1241 ± 103 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [c6e91a1]
UI Startup Metrics (1196 ± 97 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
mathieuartu
changed the title
Collaborator
Builds ready [8c4dda0]
UI Startup Metrics (1177 ± 98 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [6b718f2]
UI Startup Metrics (1256 ± 152 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
mathieuartu
changed the title
ccharly
reviewed
Nov 26, 2025
test/e2e/page-objects/pages/multichain/multichain-account-details-page.ts
Outdated
Show resolved
Hide resolved
ui/components/multichain-accounts/multichain-accounts-tree/multichain-accounts-tree.tsx
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: ButtonLink "Details" button has no click handler
The ButtonLink component rendering "Details" text lost its onClick handler when handleWalletDetailsClick was removed, but the button itself is still rendered. This component is actively used via MultichainAccountListMenu in the account list UI. Users will see a clickable "Details" button next to each wallet header that does nothing when clicked, resulting in broken UX.
ui/components/multichain-accounts/multichain-accounts-tree/multichain-accounts-tree.tsx#L70-L80
Collaborator
Builds ready [b8c1be8]
UI Startup Metrics (1324 ± 127 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [1adc393]
UI Startup Metrics (1320 ± 128 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy multichain accounts pre-state 2 UI components for account and wallet details, defaulting all navigation to the new BIP-44 based UI (state 2). The change unifies the user experience by removing dual code paths and legacy modal-based interfaces.
Key changes:
- Removed
setAccountDetailsAddressaction and associated state management - Removed legacy routes (
ACCOUNT_DETAILS_ROUTE,WALLET_DETAILS_ROUTE,ACCOUNT_DETAILS_QR_CODE_ROUTE) - Deleted legacy page components (
WalletDetails,BaseAccountDetails,AddressQRCode, and various account-details subdirectory components) - Updated navigation to use multichain state 2 routes throughout the codebase
- Cleaned up i18n strings (
walletDetails,walletNotFound*) across all locales - Updated E2E tests and page objects to work with new navigation flow
Reviewed changes
Copilot reviewed 70 out of 70 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
ui/store/actions.ts |
Removed setAccountDetailsAddress action |
ui/store/actionConstants.ts |
Removed SET_ACCOUNT_DETAILS_ADDRESS constant |
ui/ducks/app/app.ts |
Removed reducer case for setting account details address (state property remains) |
ui/pages/routes/routes.component.tsx |
Removed legacy route definitions and component imports for old account/wallet details |
ui/pages/routes/utils.js |
Removed route matching logic for legacy wallet and account details routes |
ui/helpers/constants/routes.ts |
Removed legacy route constants |
ui/components/multichain/menu-items/account-details-menu-item.js |
Updated to navigate to multichain state 2 route, removed dispatch logic |
ui/components/multichain/account-details/account-details.tsx |
Removed dispatch call to setAccountDetailsAddress |
ui/components/multichain-accounts/multichain-accounts-tree/multichain-accounts-tree.tsx |
Updated wallet navigation to use new route constant |
ui/pages/multichain-accounts/multichain-account-details-page/multichain-account-details-page.tsx |
Removed dispatch call on account removal |
ui/pages/multichain-accounts/wallet-details/* |
Deleted legacy WalletDetails component, tests, stories, and styles |
ui/pages/multichain-accounts/base-account-details/* |
Deleted BaseAccountDetails component, tests, stories, and styles |
ui/pages/multichain-accounts/address-qr-code/* |
Deleted AddressQRCode component, tests, stories, and styles |
ui/pages/multichain-accounts/account-details/* |
Deleted account-specific detail components (EVM, Solana, Bitcoin, Tron, Hardware, PrivateKey, Institutional) |
ui/pages/home/home.component.js |
Removed redirect logic that set account details address |
ui/pages/confirmations/* |
Removed references to setAccountDetailsAddress in confirmation context and tests |
test/e2e/tests/multichain-accounts/account-details.spec.ts |
Removed forceBip44Version: 2 as it's now the default |
test/e2e/page-objects/pages/multichain/* |
Added helper methods for new navigation flow (click SRP row, get truncated address) |
test/e2e/tests/vault-corruption/vault-corruption.spec.ts |
Updated E2E flow to use new account details page and address list modal |
test/e2e/flask/multi-srp/import-srp.spec.ts |
Updated SRP export flow to use multichain account details page |
app/_locales/*/messages.json |
Removed unused i18n strings for wallet details error states |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cmd-ob
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it so the UI now defaults to the multichain accounts state 2 for those areas:
Changelog
CHANGELOG entry: default to BIP-44 UI for account & wallet details
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Default account and wallet details to Multichain State 2, removing legacy UI/routes and the account-details address action, with navigation, tests, page-objects, and i18n updated accordingly.
AccountDetails,WalletDetails,AddressQRCode, andBaseAccountDetailspages/components.MULTICHAIN_*routes; removeACCOUNT_DETAILS_ROUTE,ACCOUNT_DETAILS_QR_CODE_ROUTE, andWALLET_DETAILS_ROUTE.SET_ACCOUNT_DETAILS_ADDRESSaction and related reducer/state; strip all usages.MultichainAccountDetailsPageandWalletDetailsPageonly.walletDetails,walletNotFound*) across locales.MULTICHAIN_WALLET_DETAILS_PAGE_ROUTE.Written by Cursor Bugbot for commit 1adc393. This will update automatically on new commits. Configure here.